On 2/14/22 18:35, Ilya Maximets wrote: > On 2/14/22 17:39, Stokes, Ian wrote: >>> The subtable search function can be used at any time by a PMD thread. >>> Setting the subtable search function should be done atomically to >>> prevent garbage data from being read. >>> >>> A dpcls_subtable_lookup_reprobe() call can happen at the same time that >>> DPCLS subtables are being sorted. This could lead to modifications done >>> by the reprobe() to be lost. Prevent this from happening by locking on >>> pmd->flow_mutex. After this change both the reprobe function and a >>> subtable sort will share the flow_mutex preventing modifications by >>> either one from being lost. >>> >>> Also remove the pvector_publish() call. The pvector is not being changed >>> in dpcls_subtable_lookup_reprobe(), only the data pointed to by pointers >>> in the vector are being changed. >> >> Hi Cian, >> >> Thanks for the patch, in general this looks ok to me, but I realize Ilya had >> a few comments on the v1. I think these are addressed here but maybe Ilya >> would like to confirm before sign off? > > Thanks, Ian. > I'll take a look at this patch tomorrow. > >> >> @Ilya Maximets should this go into branch 2.17 as well before release? > > I'd say, if it applies cleanly, we should try to backport it down to 2.14, > because the issue may cause OVS crash.
I didn't test it, but the change looks correct to me. Thanks! Acked-by: Ilya Maximets <i.maxim...@ovn.org> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
