On 2/11/22 15:31, Eelco Chaudron wrote:
On 28 Jan 2022, at 17:04, Adrian Moreno wrote:
Some ovs-ofctl commands are used to parse or dump openflow flows,
specially in ofp-actions.at
Use a wrapper around ovs-ofctl, called ovs-test-ofparse.py that, apart
from calling ovs-ofctl, also parses its output (or input, depending on
the command) to make sure the python flow parsing library can also parse
the flows.
Signed-off-by: Adrian Moreno <[email protected]>
Changes look good to me, one small nit below.
Acked-by: Eelco Chaudron <[email protected]>
---
tests/automake.mk | 3 ++
tests/ofp-actions.at | 46 +++++++++----------
tests/ovs-test-ofparse.py | 94 +++++++++++++++++++++++++++++++++++++++
3 files changed, 120 insertions(+), 23 deletions(-)
create mode 100755 tests/ovs-test-ofparse.py
<SNIP>
diff --git a/tests/ovs-test-ofparse.py b/tests/ovs-test-ofparse.py
new file mode 100755
index 000000000..bf578b6d5
--- /dev/null
+++ b/tests/ovs-test-ofparse.py
@@ -0,0 +1,94 @@
+#!/usr/bin/env python3
+
NIT: You removed the entire copyright header, I was only referring to the part
below. But I’m fine with it.
-+# Breaks lines read from stdin into groups using blank lines as
-+# group separators, then sorts lines within the groups for
-+# reproducibility.
Oh! Right, I'll restore the copyright header.
+""" ovs-test-ofparse is just a wrapper around ovs-ofctl
+ that also runs the python flow parsing utility to check that flows are
+ parseable.
+"""
+
+import subprocess
+import sys
+import re
+
+from ovs.flows.ofp import OFPFlow
+
Thanks
--
Adrián Moreno
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
