On 2/25/22 14:10, Eelco Chaudron wrote: > > > On 15 Feb 2022, at 5:34, lic121 wrote: > >> If lldp didn't change, we are not supposed to trigger backer >> revalidation. >> Without this patch, bridge_reconfigure() always trigger udpif >> revalidator because of lldp. >> >> This patch also fix lldp memory leak bug: >> lldp_create() malloc memory for lldp->lldpd->g_hardware. lldp_unref >> is supposed to free the memory, but it doesn't. >> >> Signed-off-by: lic121 <lic...@chinatelecom.cn> >> Signed-off-by: Eelco Chaudron <echau...@redhat.com> >> Co-authored-by: Eelco Chaudron <echau...@redhat.com> > > Changes look good to me! > > Acked-by: Eelco Chaudron <echau...@redhat.com>
Hi. This patch triggers conntrack system test failure: 95: conntrack - zone-based timeout policy FAILED (system-traffic.at:4099) .... ./system-traffic.at:4089: ovs-vsctl del-zone-tp $DP_TYPE zone=5 ./system-traffic.at:4092: ip netns exec at_ns0 sh << NS_EXEC_HEREDOC ping -q -c 3 -i 0.3 -w 2 10.1.1.2 | grep "transmitted" | sed 's/time.*ms$/time 0ms/' NS_EXEC_HEREDOC ./system-traffic.at:4095: ovs-ofctl -O OpenFlow13 packet-out br0 "in_port=1 packet=50540000000a50540000000908004500001c000000000011a4cd0a0101010a0101020001000200080000 actions=resubmit(,0)" ./system-traffic.at:4099: ovs-appctl dpctl/dump-conntrack | grep "dst=10.1.1.2" | sed -e 's/port=[0-9]*/port=<cleared>/g' -e 's/id=[0-9]*/id=<cleared>/g' -e 's/state=[0-9_A-Z]*/state=<cleared>/g' | sort | uniq | sort --- - 2022-03-04 14:59:39.771970942 -0500 +++ /root/ovs/tests/system-kmod-testsuite.dir/at-groups/95/stdout 2022-03-04 14:59:39.768680736 -0500 @@ -1,3 +1 @@ -icmp,orig=(src=10.1.1.1,dst=10.1.1.2,id=<cleared>,type=8,code=0),reply=(src=10.1.1.2,dst=10.1.1.1,id=<cleared>,type=0,code=0),zone=5 -udp,orig=(src=10.1.1.1,dst=10.1.1.2,sport=<cleared>,dport=<cleared>),reply=(src=10.1.1.2,dst=10.1.1.1,sport=<cleared>,dport=<cleared>),zone=5 It looks like timeout policy removal doesn't trigger reconfiguration of the conntrack, i.e. timeout stays the same. Sounds like we have a bug in the conntrack code, but it was hidden by revalidation triggered for lldp. I'm afraid we need to fix that conntrack issue before this patch can be accepted. This test is part of the 'make check-kernel' testsuite and the failure is 100% reproducible on my setup. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
