On Mon, Jan 24, 2022 at 01:39:57PM -0500, Mike Pattrick wrote:
> On Tue, Dec 7, 2021 at 11:53 AM Flavio Leitner <f...@sysclose.org> wrote:
> >
> > Currently 'p' and 'b' and used for packets, so use
> > a convention that struct dp_packet is 'p' and
> > struct dp_packet_batch is 'b'.
> >
> > Some comments needed new formatting to not pass the
> > 80 column.
> >
> > Some variables were using 'p' or 'b' were renamed
> > as well.
> >
> > There should be no functional change with this patch.
> >
> > Signed-off-by: Flavio Leitner <f...@sysclose.org>
> > ---
> 
> I think this patch goes a long way to improve the readability of Would
> it also make sense to change b to p in lib/packets.c and
> lib/netdev-linux.c as well?

I think 'b' meant buffer before, but IMHO 'b' for batches
and 'p' for packets make more sense and then we should 
keep the consistency in all files, unless someone else
has a better idea.

-- 
fbl
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to