On Thu, Mar 10, 2022 at 1:51 PM Ilya Maximets <i.maxim...@ovn.org> wrote: > > On 3/10/22 13:12, David Marchand wrote: > > The hacking flake8 plugin generates a lot of noise in GHA logs about an > > issue on the Apache license contained in OVS python files: > > https://github.com/openvswitch/ovs/runs/5453426047?#step:11:1519 > > > > Those prints seem like a bug in the hacking plugin [1] as the check > > about the license is not enabled in OVS checks. > > > > Though, when comparing with https://www.apache.org/licenses/LICENSE-2.0, > > OVS files have an additional ':'. > > > > Align all files in OVS with the official notice and enable the check to > > avoid reintroducing a wrong notice. > > > > 1: > > https://github.com/openstack/hacking/blob/4.1.0/hacking/checks/comments.py#L168 > > > > Signed-off-by: David Marchand <david.march...@redhat.com> > > --- > > Hi, David. > > OVS doesn't enable H103 check, so I think that the problem is in > the hacking plugin itself. It prints the license comparison > unconditionally even if the check wasn't requested. > > I actually prepared a fix for hacking a couple of weeks ago: > https://review.opendev.org/c/openstack/hacking/+/830537
Thanks, that saves me the time to fix it :-). > Had no responses yet, though... :( I reviewed your change, let's see if it helps... -- David Marchand _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
