On Tue, Mar 22, 2022 at 2:36 PM Ilya Maximets <i.maxim...@ovn.org> wrote:
>
> OVS_WAIT_UNTIL() macro has only 2 arguments and doesn't check the
> output of the command, but bonding and route tests are trying to use
> it as if it was AT_CHECK macro. That makes checks in those tests
> mostly useless, since they are not actually checking anything except
> for command returning zero.
>
> Introducing a new macro OVS_WAIT_UNTIL_EQUAL that will actually
> perform the comparison with the desired output. Using it for
> the bonding and route tests and fixing all the caught incorrect
> expected outputs along the way.
>
> Adding an explicit argument check to the OVS_WAIT_UNTIL/WHILE to
> avoid the problem in the future.
I tried to pass incorrect arguments to those macros and it behaves as I expect.
Since my proposal on v1 is too complex, this simple added check looks
good enough.
Thanks.
>
> Fixes: b4e50218a0f8 ("bond: Add 'primary' interface concept for active-backup
> mode.")
> Fixes: 9e11517e6ca6 ("ovs-router: Fix flushing of local routes.")
> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org>
Reviewed-by: David Marchand <david.march...@redhat.com>
I wanted to run this patch in GHA because the robot reported one issue
with one job, but I get strange Internal Server errors when pushing in
my own github repo.
Oh oh... I hope it is only temporary.
At least UT pass fine on my system with this patch.
--
David Marchand
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
