Hi Numan, Is it ok if we make the “gateway_port” column optional in a subsequent patch? Will send out a v5 patch that addresses other comments.
Thanks, Abhiram Sangana > On 30 Mar 2022, at 19:32, Numan Siddique <num...@ovn.org> wrote: > > On Wed, Mar 30, 2022 at 1:41 PM Abhiram Sangana > <sangana.abhi...@nutanix.com> wrote: >> >> Hi Numan, >> >> Thanks for reviewing the patch >> >> On 30 Mar 2022, at 16:55, Numan Siddique >> <num...@ovn.org<mailto:num...@ovn.org>> wrote: >> >> I think the "gateway_port" column can be a weak reference to >> "Logical_Router_Port". >> Otherwise CMS cannot delete the logical router port unless it clears >> this column or deletes the NAT row. >> >> My bad. Will change this column to be a weak reference to LRP. > > No worries. I guess it would make sense to have a strong reference if > we go with the approach to make it mandatory for CMS > to specify gateway_port. > > But since we can determine the gateway_port ourselves, this can be > optional and weak reference. >> >> >> IMO, this column should be made optional. If CMS doesn''t specify the >> gateway port to use for a NAT entry, >> ovn-northd can figure out which router port is reachable for the >> "external_ip" of the NAT. >> ovn-northd already does this for the Logical_Router_Static_Route's >> output_port column. >> >> >> I'd suggest making this column optional. What do you think ? >> >> Got it. So, if we make this column optional, is this the behaviour >> that we want? >> >> If LR has a single DGP and “gateway_port” is not specified, we program >> the NAT rule with the DGP even if "external_ip" of the rule is not in >> the LRP networks. >> >> If LR has multiple DGPs and "gateway_port" is not specified, we try >> to determine which DGP is appropriate based on the LRP networks and >> "external_ip" of the rule. If no DGP matches, we do not program the >> NAT rule. >> >> Is the current behaviour of ovn-nbctl ok? > > Yes. But I'd suggest ovn-northd determine the appropriate DGP and not > ovn-nbctl > if CMS doesn't specify the gateway_port. > > Numan > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
