On 3/28/22 15:55, David Marchand wrote: > On Wed, Mar 23, 2022 at 2:08 PM Mike Pattrick <m...@redhat.com> wrote: >> >> On Wed, Mar 23, 2022 at 4:23 AM David Marchand >> <david.march...@redhat.com> wrote: >>> >>> On Tue, Mar 22, 2022 at 6:43 PM Mike Pattrick <m...@redhat.com> wrote: >>>> >>>> In glibc 2.32 sys_siglist is no longer exported. The MT-safe function >>>> sigdescr_np() is now available for the same purpose. >>> >>> I am not familiar with this, but a quick search returns: >>> https://www.gnu.org/software/gnulib/manual/html_node/sigdescr_005fnp.html >>> >>> """ >>> Note: This function is hardly useful, because it returns English >>> strings, not internationalized strings. Better use the function >>> strsignal, which returns internationalized strings. >>> """ >>> >>> Now reading strsignal manual, it seems to be POSIX, and a replacement >>> for direct access to sys_siglist... ? >> >> Frustratingly, it's not MT safe. > > Interesting... > And I found that there is a check for not adding strsignal in OVS too. > > > The change looks good to me. > I tested compilation only, on systems I have atm: i.e. RHEL7 (glibc > 2.17), RHEL8 (glibc 2.28) and FC35 (glibc 2.34). > > > Reviewed-by: David Marchand <david.march...@redhat.com>
Thanks! Applied. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
