On 4/15/22 23:42, Greg Rose wrote:
> Remove kernel based github workflows since the OVS kernel driver is
> no longer supported since Release 2.17
> 
> Signed-off-by: Greg Rose <gvrose8...@gmail.com>
> ---

Hi Greg,

>  .github/workflows/build-and-test.yml | 35 ----------------------------
>  1 file changed, 35 deletions(-)
> 
> diff --git a/.github/workflows/build-and-test.yml 
> b/.github/workflows/build-and-test.yml
> index eac3504e4..cf483dc1e 100644
> --- a/.github/workflows/build-and-test.yml
> +++ b/.github/workflows/build-and-test.yml
> @@ -9,16 +9,9 @@ jobs:
>          automake libtool gcc bc libjemalloc1 libjemalloc-dev    \
>          libssl-dev llvm-dev libelf-dev libnuma-dev libpcap-dev  \
>          ninja-build selinux-policy-dev
> -      deb_dependencies: |
> -        linux-headers-$(uname -r) build-essential fakeroot devscripts equivs
> -      AFXDP:       ${{ matrix.afxdp }}
> -      ASAN:        ${{ matrix.asan }}
>        CC:          ${{ matrix.compiler }}
> -      DEB_PACKAGE: ${{ matrix.deb_package }}
>        DPDK:        ${{ matrix.dpdk }}
>        DPDK_SHARED: ${{ matrix.dpdk_shared }}
> -      KERNEL:      ${{ matrix.kernel }}
> -      KERNEL_LIST: ${{ matrix.kernel_list }}
>        LIBS:        ${{ matrix.libs }}
>        M32:         ${{ matrix.m32 }}
>        OPTS:        ${{ matrix.opts }}
> @@ -37,14 +30,6 @@ jobs:
>            - compiler:     clang
>              opts:         --disable-ssl
>  
> -          - compiler:     gcc
> -            testsuite:    test
> -            kernel:       3.16
> -          - compiler:     clang
> -            testsuite:    test
> -            kernel:       3.16
> -            asan:         asan
> -

Maybe it's enough to just remove the 'kernel' argument here?  It's
useful to have address sanitizer enabled test jobs too.  Arguably, when
we added it we should've maybe not link it to a given kernel but, in any
case, I think we shouldn't remove it completely now.

What do you think of keeping it as:

- compiler:     clang
  testsuite:    test
  asan:         asan

I might be wrong but it seems to me we need something similar for afxdp too.

Regards,
Dumitru

>            - compiler:     gcc
>              testsuite:    test
>              opts:         --enable-shared
> @@ -66,23 +51,6 @@ jobs:
>              testsuite:    test
>              libs:         -ljemalloc
>  
> -          - compiler:     gcc
> -            kernel_list:  5.8 5.5 5.4 4.19
> -          - compiler:     clang
> -            kernel_list:  5.8 5.5 5.4 4.19
> -
> -          - compiler:     gcc
> -            kernel_list:  4.14 4.9 4.4 3.16
> -          - compiler:     clang
> -            kernel_list:  4.14 4.9 4.4 3.16
> -
> -          - compiler:     gcc
> -            afxdp:        afxdp
> -            kernel:       5.3
> -          - compiler:     clang
> -            afxdp:        afxdp
> -            kernel:       5.3
> -
>            - compiler:     gcc
>              dpdk:         dpdk
>              opts:         --enable-shared
> @@ -106,9 +74,6 @@ jobs:
>              m32:          m32
>              opts:         --disable-ssl
>  
> -          - compiler:     gcc
> -            deb_package:  deb
> -
>      steps:
>      - name: checkout
>        uses: actions/checkout@v2

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to