On Tue, Apr 19, 2022 at 01:38:33AM +0000, Jianbo Liu via dev wrote: > On Thu, 2022-04-07 at 09:15 +0000, Jianbo Liu wrote: > > This series is to add support for tc offloading of ovs metering, and > > enhance OVS to use new kernel feature which offload tc police action to > > hardware. > > To do the offloading, new APIs for meter are added in netdev-offload, > > and OVS meters are mapped to tc police actions with one-to-one > > relationship for dpif-netlink. > > > > Notes: > > v3 > > - Add netdev-offload APIs for meter. > > - Move the implementation to lower netdev-offload-tc layer. > > > > v2 > > - Move tc police parse call from last patch to 2nd patch. > > 2nd patch is adding the parse lib func and add the call to it in > > that patch. > > Last patch is the put of tc police act. > > In 2nd patch also add empty switch case for tc police act put as > > the impl. > > is done in the last patch when support for put is being added.
... > Friendly ping for review. Hi Jianbo, sorry for the delayed response. My colleagues at Corigine have exercised this patchset and have verified it for our test-cases. Also, I have run the upstream test workflows over them, and they look good. 1. netdev-offload: Add meter offload provider https://github.com/horms2/ovs/actions/runs/2220399423 2. tc: Add support parsing tc police action https://github.com/horms2/ovs/actions/runs/2220409233 3. netdev-linux: Refactor put police action netlink message https://github.com/horms2/ovs/actions/runs/2220516986 4. netdev-linux: Add functions to manipulate tc police action https://github.com/horms2/ovs/actions/runs/2220566774 5. netdev-offload-tc: Implement and register meter offload API for tc https://github.com/horms2/ovs/actions/runs/2220568491 6. netdev-offload-tc: Cleanup police actions with reserved indexes on startup https://github.com/horms2/ovs/actions/runs/2220569761 7. netdev-offload-tc: Offloading rules with police actions https://github.com/horms2/ovs/actions/runs/2220571039 8. dpif-netlink: Offloading meter to tc police action https://github.com/horms2/ovs/actions/runs/2220572904 I have also reviewed the patches, and with my OVS maintainer hat on, I'm happy to apply them, and plan to do so in the coming days unless there are objections. One area that we, at Corigine, would like to follow-up on is using a revalidation process rather than evicting rules on start-up. Kind regards, Simon _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
