--------------
Han Ding
>
>
>On 5/6/22 11:04, Adrian Moreno wrote:
>> Hello,
>>
>> On 4/18/22 10:01, handing wrote:
>>>
>>> When setting just one ofp version to protocols of bridge, The function
>>> get_highest_ofp_version in ovs-save parse it error.
>>>
>>> For example:
>>> $ ovs-vsctl get bridge br-int protocols
>>> [OpenFlow15]
>>>
>>> $ ovs-vsctl get bridge br-int protocols |
>>> sed 's/[][]//g' | sed 's/\ //g' | awk -F ',' '{ print (NF>1)? $(NF) :
>>> "OpenFlow14" }'
>>> OpenFlow14
>>>
>>> Signed-off-by: handing <hand...@chinatelecom.cn>
>>
>> I think we need the full name of the author in the Signed-off-by tag as per
>
>Sorry: unfinished sentence. My intention was to reference this doc:
>https://docs.openvswitch.org/en/latest/internals/contributing/submitting-patches/
Thanks for reviewing. I will modify it in next version.
>>
>>> ---
>>> utilities/ovs-save | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/utilities/ovs-save b/utilities/ovs-save
>>> index fb2025b76..a190902f4 100755
>>> --- a/utilities/ovs-save
>>> +++ b/utilities/ovs-save
>>> @@ -102,7 +102,7 @@ save_interfaces () {
>>> get_highest_ofp_version() {
>>> ovs-vsctl get bridge "$1" protocols | \
>>> sed 's/[][]//g' | sed 's/\ //g' | \
>>> - awk -F ',' '{ print (NF>1)? $(NF) : "OpenFlow14" }'
>>> + awk -F ',' '{ print (NF>0)? $(NF) : "OpenFlow14" }'
>>> }
>>>
>>> save_flows () {
>>> --
>>> 2.27.0
>>>
>>>
>>
>> The change itself looks good to me. Apart from the formal comment above:
>>
>> Acked-by: Adrian Moreno <amore...@redhat.com>
>>
>
>--
>Adrián Moreno
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
