On Fri, May 13, 2022 at 8:34 AM Jochen Friedrich via dev <
ovs-dev@openvswitch.org> wrote:

> Add ovn-encap-df_default configuration option to set df_default on OVN
> tunnels.
>
> Signed-off-by: Jochen Friedrich <joc...@scram.de>
>

Thanks for the v2.

The patch LGTM.  Can you please also add the documentation about the new
option somewhere here -
https://github.com/ovn-org/ovn/blob/main/controller/ovn-controller.8.xml#L178

Thanks
Numan

> ---
>  controller/encaps.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/controller/encaps.c b/controller/encaps.c
> index ed01b1368..0ad8fe16c 100644
> --- a/controller/encaps.c
> +++ b/controller/encaps.c
> @@ -190,6 +190,13 @@ tunnel_add(struct tunnel_ctx *tc, const struct
> sbrec_sb_global *sbg,
>              smap_add(&options, "tos", encap_tos);
>          }
>
> +        /* If the df_default option is configured, get it */
> +
> +        const char *encap_df = smap_get(&cfg->external_ids,
> "ovn-encap-df_default");
> +        if (encap_df) {
> +            smap_add(&options, "df_default", encap_df);
> +        }
> +
>          /* If ovn-set-local-ip option is configured, get it */
>          set_local_ip = smap_get_bool(&cfg->external_ids,
> "ovn-set-local-ip",
>                                       false);
> --
> 2.27.0
>
> _______________________________________________
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to