On 5/10/22 20:33, Rosemarie O'Riorden wrote:
> The FreeBSD CI builds keep failing because processes of tests are not
> properly killed. This leaves the build hanging until it times out, and
> ultimately fails.
>
> Changes name of pidfile pid2 to 2.pid so that the
> on_exit 'kill `cat *.pid`' will capture all pidfiles.
>
> Fixes pidfile name logic in test that uses OVSDB_SERVER_SHUTDOWN_N, so
> that all pidfile names match the form *.pid.
>
> Replaces unnecessary --pidfile="`pwd`"/pid with just --pidfile, because
> by default this argument creates a pidfile named <proc-name>.pid.
>
> Removes extra [test ! -e pid || kill `cat pid`] that run upon AT_CHECK
> failure, because those processes are killed with on_exit. Also adds
> on_exit in tests where it was missing.
>
> Fixes: 561205007e ("tests: Get rid of overly specific --pidfile and --unixctl
> options.")
> Fixes: 0be15ad76f ("ovsdb-server.at: Add unit test for record/replay.")
> Fixes: 7964ffe7d2 ("ovsdb: relay: Add support for transaction forwarding.")
> Fixes: e879d33e83 ("ovsdb/jsonrpc-server: ovsdb-server closes accepted
> connections immediately.")
> Fixes: 7ed9240836 ("ovsdb-client: Move ovsdb-client specific tests to new .at
> file.")
> Signed-off-by: Rosemarie O'Riorden <[email protected]>
> ---
> - v1 was an outdated work-in-progress
> - Fixes OVSDB_SERVER_SHUTDOWN_N, pidfile names, removes unnecessary
> process kills.
>
> tests/ovsdb-client.at | 3 ++
> tests/ovsdb-server.at | 110 ++++++++++++++++++------------------------
> 2 files changed, 51 insertions(+), 62 deletions(-)
This literally saves hours when applying patches.
Thanks for tracking all these processes down!
Applied and backported down to 2.13.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
