Title should be: "ofproto-dpif: Fix meter use-after-free." On Wed, May 25, 2022 at 3:36 AM Peng He <xnhp0...@gmail.com> wrote: > > add a rcu_barrier before close_dpif_backer to ensure that
Add* > all meters has been freed before id_pool_destory meter's have* > id-pool. > > Signed-off-by: Peng He <hepeng.0...@bytedance.com> > Tested-by: David Marchand <david.march...@redhat.com> > Acked-by: Eelco Chaudron <echau...@redhat.com> > --- > ofproto/ofproto-dpif.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index 6601f2346..0d0d985f0 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofproto-dpif.c > @@ -1848,6 +1848,8 @@ destruct(struct ofproto *ofproto_, bool del) > > seq_destroy(ofproto->ams_seq); > > + /* Wait for all the meter destroy work to finish */ to finish.* > + ovsrcu_barrier(); > close_dpif_backer(ofproto->backer, del); > } > > -- > 2.25.1 > Reviewed-by: David Marchand <david.march...@redhat.com> -- David Marchand _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
