> -----Original Message-----
> From: Amber, Kumar <kumar.am...@intel.com>
> Sent: Tuesday 31 May 2022 15:01
> To: ovs-dev@openvswitch.org
> Cc: echau...@redhat.com; i.maxim...@ovn.org; Ferriter, Cian
> <cian.ferri...@intel.com>; Stokes, Ian
> <ian.sto...@intel.com>; david.march...@redhat.com; f...@sysclose.org; Van
> Haaren, Harry
> <harry.van.haa...@intel.com>; Amber, Kumar <kumar.am...@intel.com>
> Subject: [PATCH v10 3/4] dpif-netdev/mfex: Add AVX512 ipv6 traffic profiles
>
> Add AVX512 Ipv6 optimized profile for vlan/IPv6/UDP and
> vlan/IPv6/TCP, IPv6/UDP and IPv6/TCP.
>
> MFEX autovalidaton test-case already has the IPv6 support for
> validating against the scalar mfex.
>
> Signed-off-by: Kumar Amber <kumar.am...@intel.com>
> Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com>
> Co-authored-by: Harry van Haaren <harry.van.haa...@intel.com>
>
> ---
> v10:
> - Rebase on top of Partial Avx512 changes patch.
Thanks for rebasing on top of my AVX512 build changes and following the same
patterns with your changes here Amber, from a code review it all looks good.
I also tested with GCC 4.8, 4.9, 5 and 9. They are all working as expected with
the respective configure outputs, config.h content and actual AVX512
implementations correctly working.
> v9:
> - Fix Ubscan memory alinged access.
<snip lots of the diff>
> +
> +/* IPv6 Protocol specific helper functions, for handling L4 UDP/TCP. */
> +static inline void
> +mfex_handle_ipv6_l4(const uint8_t *ports, uint64_t *block)
> +{
> + memcpy(block, ports, sizeof(uint32_t));
> +}
> +
ACK the new memcpy approach to be UB safe, looking at the ASM before and
afterwards, it looks the same to me. Nice
<snip the rest of the diff>
Acked-by: Cian Ferriter <cian.ferri...@intel.com>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
