On Wed, Jun 1, 2022 at 1:26 PM Terry Wilson <twil...@redhat.com> wrote:
>
> Since pids can be re-used, it is necessary to check that the
> process that is running with a pid matches the one that we expect.
>
> This adds the ability to optionally pass a 'binary' argument to
> pidfile_is_running, and if it is passed to match the binary against
> /proc/$pid/exe.
>
> Signed-off-by: Terry Wilson <twil...@redhat.com>
> ---
> ovs | 2 +-
Why do you bump the submodule in this patch?
> utilities/ovn-ctl | 9 ++++++++-
> 2 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/ovs b/ovs
> index d7c0b90fa..91e1ff5dd 160000
> --- a/ovs
> +++ b/ovs
> @@ -1 +1 @@
> -Subproject commit d7c0b90fa360a694f0f3b4f4ce1c514fec4e4359
> +Subproject commit 91e1ff5dde396fbcc8623ac0726066e970e6de15
> diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
> index d733aa42d..41fa89770 100755
> --- a/utilities/ovn-ctl
> +++ b/utilities/ovn-ctl
> @@ -40,9 +40,16 @@ ovn_ic_db_conf_file="$ovn_etcdir/ovn-ic-db-params.conf"
> ## start ##
> ## ----- ##
>
> +pid_exe_matches () {
> + pid=$1
> + binary=$2
> + [ -z "$binary" -o `readlink /proc/$pid/exe` = "$binary" ]
> +}
> +
> pidfile_is_running () {
> pidfile=$1
> - test -e "$pidfile" && [ -s "$pidfile" ] && pid=`cat "$pidfile"` &&
> pid_exists "$pid"
> + binary=$2
> + test -e "$pidfile" && [ -s "$pidfile" ] && pid=`cat "$pidfile"` &&
> pid_exists "$pid" && pid_exe_matches "$pid" "$binary"
> } >/dev/null 2>&1
>
> stop_nb_ovsdb() {
> --
> 2.34.3
>
> _______________________________________________
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
