On 3/18/22 11:28, Eelco Chaudron wrote: > > > On 11 Mar 2022, at 16:21, Adrian Moreno wrote: > >> In order to minimize the risk of having the python flow parsing code and >> the C flow formatting code divert, add a target that checks if the >> formatting code has been changed since the last revision and warn the >> developer if it has. >> >> The script also makes it easy to update the dependency file so hopefully >> it will not cause too much trouble for a developer that has modifed the >> file without changing the flow string format.
Ugh. Trying to work with this change applied is very annoying. :) I mean, odp-util.c is getting changed frequently, and you have to update the hash every time you change it during development, otherwise the build fails. I'd like to not have this patch. The previous two should cover most of the cases, assuming people are adding tests for every new match/action they are adding. And they really should. Best regards, Ilya Maximets. >> >> Signed-off-by: Adrian Moreno <amore...@redhat.com> >> --- > > Changes look good to me! > > Acked-by: Eelco Chaudron <echau...@redhat.com> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
