On 7/12/2022 1:26 PM, David Marchand wrote:
On Tue, Jul 12, 2022 at 8:03 PM Greg Rose <gvrose8...@gmail.com> wrote:
Remove the kernel driver specification for RHEL 6.x, 7.x, 8.x and Fedora.
Signed-off-by: Greg Rose <gvrose8...@gmail.com>
The patch lgtm.
I suggest a title like:
rhel: Stop packaging OVS kernel module.
You can add:
Reviewed-by: David Marchand <david.march...@redhat.com>
Again, the title is an accurate description, I'll go ahead
and use it.
I have some comments/questions.
Feel free to ignore them if you think it is unrelated, we can revisit
this later.
- I am unsure on what to do with
rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh.
I am not sure it makes sense to keep it.
Yep, I'll get rid of it also.
- Both rhel/openvswitch-fedora.spec.in and rhel/openvswitch.spec.in
were mentionning:
"""
# These tests will use the currently installed OVS kernel modules, when
# testing out of tree kernel modules the appropriate openvswitch-kmod
# package should be installed first.
"""
That I would rephrase as:
"""
# These tests will use the currently installed OVS kernel modules.
"""
- And the Fedora spec file had a reference to GPL v2 license for
datapath/ files.
"""
# datapath/ is GPLv2 (although not built into any of the binary packages)
"""
I'll fix those up and roll it up into V5.
Thanks,
- Greg
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
