On 14 Jul 2022, at 15:04, Van Haaren, Harry wrote:
>> -----Original Message----- >> From: Eelco Chaudron <[email protected]> >> Sent: Thursday, July 14, 2022 1:55 PM >> To: Van Haaren, Harry <[email protected]>; Finn, Emma >> <[email protected]> >> Cc: [email protected]; [email protected]; Amber, Kumar >> <[email protected]>; Pai G, Sunil <[email protected]>; Stokes, Ian >> <[email protected]> >> Subject: Re: [PATCH v10 00/10] Actions Infrastructure + Optimizations > > <snip cover letter contents> > >>> V10; >>> - Fixed CI build issue on OSX around AVX512 linking (jenkins CI) >>> - Moved docs and reworded sections (thanks Ilya for feedback) >>> - Reworked one instance of <= OVS_ATTR_MAX back to original form(Eelco) >> >> I’ve just finished my review purely based on visual inspection and compile >> success, >> and I will send out some minor comments after the break ;) > > Sure - please keep in mind that theres few working hours before merge window > ends, > so unless absolutely critical to fix *before* merge, we can fixup things next > week. > > To be very clear; if there a genuine issue, yes lets fix. Variable renames, > tidys etc, > can all be handled starting from next week. > >> After that, I will do the actual functional testing on an AVX512 machine and >> let you >> know the results. This will give you time to fix/discuss the comment while >> I’m >> testing. > > Looking forward! They should be in your inbox, most of them can be changed quickly, just sent out the v11 once done, as I need time to test this anyway before I can give my final ACKs. My plan is to test v10 (or v11 if it’s there) tomorrow. //Eelco _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
