On 8/2/22 12:31, Dumitru Ceara wrote: > On 7/29/22 19:52, Ilya Maximets wrote: >> On 7/29/22 08:05, Ales Musil wrote: >>> >>> On Thu, Jul 28, 2022 at 5:43 PM Ilya Maximets <i.maxim...@ovn.org >>> <mailto:i.maxim...@ovn.org>> wrote: >>> >>> LeakSanitizer for some reason reports these json objects as leaked, >>> even though we do have references to them at the moment ovs_fatal() >>> called from check_ovsdb_error(). >>> >>> Previously it complained only with -O2, but with newer versions of >>> clang/llvm it started complaining even with -O1. For example, negative >>> ovsdb parsing tests are failing on ubuntu 22.04 with clang 14 if built >>> with ASan and detect_leaks=1. >>> >>> Fix that by destroying the json object before aborting the process. >>> And we may also build with default -O2 in CI with that change. >>> >>> Alternative implementation might be to just pass the json to destroy >>> to every check_ovsdb_error() call, but indirect registering of the >>> pointer seems a bit less invasive. >>> >>> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org >>> <mailto:i.maxim...@ovn.org>> >>> --- >>> .ci/linux-build.sh | 6 ++--- >>> tests/test-ovsdb.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++ >>> 2 files changed, 63 insertions(+), 4 deletions(-) >>> >>> >>> Hi Ilya, >>> >>> I actually saw that couple of times even when running the OVN tests. >>> >>> Acked-by: Ales Musil <amu...@redhat.com <mailto:amu...@redhat.com>> >> >> Thanks! Applied and backported down to 2.17 to avoid possible issues >> on a future LTS branch. >> > > Hi, Ales, Ilya, > > Do you guys plan to send a similar patch for OVN too? >
Actually, after Ales reached out off-list, it turns out the failures I remembered seeing in OVN CI are different [0] and we need to investigate them separately. Sorry for the noise. Regards, Dumitru [0] https://github.com/ovsrobot/ovn/runs/7337939413?check_suite_focus=true _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
