On 8/3/22 17:19, Mike Pattrick wrote:
> On Wed, Aug 3, 2022 at 11:12 AM Ilya Maximets <i.maxim...@ovn.org> wrote:
>>
>> On 8/3/22 16:58, Mike Pattrick wrote:
>>> On Thu, Jul 28, 2022 at 2:27 PM Ilya Maximets <i.maxim...@ovn.org> wrote:
>>>>
>>>> $NC_EOF_OPT should be used to avoid some netcat implementations
>>>> to wait indefinitely.
>>>>
>>>> This fixes the check-offloads testsuite hanging in Ubuntu 22.04.
>>>>
>>>> Fixes: 5660b89a309d ("dpif-netlink: Offloading meter to tc police action")
>>>> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org>
>>>
>>> Should we also add these flags to the other system tests?
>>
>> I thought all other client-side nc calls already have them.
>> Did I miss some?
> 
> tests/system-traffic.at:5263:NS_CHECK_EXEC([at_ns0], [echo "TEST" | nc
> -p 30000 10.1.1.2 80 > nc-1.log])
> tests/system-traffic.at:5269:NS_CHECK_EXEC([at_ns0], [echo "TEST2" |
> nc -p 30001 172.1.1.2 80 > nc-2.log])
> tests/system-traffic.at:5270:NS_CHECK_EXEC([at_ns0], [echo "TEST3" |
> nc -p 30001 10.1.1.2 80 > nc-3.log])
> tests/system-traffic.at:6659:    NS_CHECK_EXEC([at_ns1], [echo "TEST1"
> | nc -p 4100$i 10.1.1.64 80 > nc-1-$i.log])
> tests/system-traffic.at:6660:    NS_CHECK_EXEC([at_ns5], [echo "TEST5"
> | nc -p 4100$i 10.1.1.64 80 > nc-5-$i.log])

Hmm. OK.  We should probably fix those too in a separate patch.

> 
>>
>>>
>>> Acked-by: Mike Pattrick <m...@redhat.com>
>>>
>>>> ---
>>>>  tests/system-offloads-traffic.at | 8 ++++----
>>>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
> 

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to