On Fri, Jul 29, 2022 at 04:53:15PM +0200, Ilya Maximets wrote: > @@ -606,8 +606,9 @@ flower_tun_opt_to_match(struct match *match, struct > tc_flower *flower) > len -= sizeof(struct geneve_opt) + opt->length * 4; > } > > - match->wc.masks.tunnel.metadata.present.len = > - flower->mask.tunnel.metadata.present.len; > + /* In the 'flower' mask len is an actual length, not the mask. > + * But in 'match' it is an actual mask and should be an exact match. */ > + match->wc.masks.tunnel.metadata.present.len = 0xff; > match->wc.masks.tunnel.flags |= FLOW_TNL_F_UDPIF; > }
I (a bit briefly) reviewed the pathset now. Overall it LGTM but I won't add a reviewed-by then. Anyhow, it would be nice if this difference was even clearer. Otherwise, it is very possible that this will be hit again in the future. It is almost impossible to catch this on code reviews later on if not deep in the context. Simple field renaming is not an option, because both are using struct tun_metadata. Cheers, Marcelo _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
