when segmentation fault occured in ovn-northd,monitor will try to
restart the ovn-northd daemon process every 10s.
Assume the following scenarios: There is a segmentation fault and
the ovn-northd daemon process does not restart properly everytime.
New fds are created each time the ovn-northd daemon process is
restarted by the monitor process,but old fds(fd[1]) ownered by
the monitor process not closed properly.One pipe remains for
each restart of the ovn-northd daemon process,After a long time
the OS`s pipe are exhausted.

Signed-off-by: Fengqi Li <[email protected]>
---
 lib/daemon-unix.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/daemon-unix.c b/lib/daemon-unix.c
index 52f3d4bc6..3e595687f 100644
--- a/lib/daemon-unix.c
+++ b/lib/daemon-unix.c
@@ -412,6 +412,7 @@ monitor_daemon(pid_t daemon_pid)
                 }
                 last_restart = time(NULL);
 
+                close(daemonize_fd);
                 VLOG_ERR("%s, restarting", status_msg);
                 child_ready = !fork_and_wait_for_startup(&daemonize_fd,
                                                          &daemon_pid);
-- 
2.27.0

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to