Hi Mike, Mike Pattrick, Aug 31, 2022 at 18:09: > On Wed, Aug 3, 2022 at 4:58 AM Robin Jarry <rja...@redhat.com> wrote: > > dropped += netdev_dpdk_eth_tx_burst(dev, qid, pkts, cnt); > > + stats.tx_failure_drops += dropped; > > Hello Robin, > > I think this will double count tx_failure_drops if there were any in > netdev_dpdk_common_send().
You are correct, I will fix this. > > + dropped = stats.tx_mtu_exceeded_drops + > > + stats.tx_qos_drops + > > + stats.tx_failure_drops + > > + stats.tx_invalid_hwol_drops; > > I'm not too clear on why we have to recalculate this, what case would > ccase dropped to be incorrect here. I'll change the logic a bit. This is awkward. Thanks for reviewing! _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
