On 6/28/22 14:35, Dumitru Ceara wrote: > On 6/27/22 10:52, Xavier Simonart wrote: >> OVN checks whether ovn-installed is already present (in OVS) before updating >> it. >> This might cause ovn-installed related issues in the following case: >> - (1) ovn-installed is present >> - (2) we claim the interface >> - (3) we update ovs, removing ovn-installed and start installing flows >> - (4) (next loop), after flows installed, we check if ovn-installed is >> absent, >> and if yes, we update OVS with ovn-installed. >> However, in step4, if OVS is still busy from step 3, ovn-installed is read as >> present; hence OVN controller does not update it and move to INSTALLED state. >> >> Note that this does not happen with writing port up in SBDB because Port >> status >> changes will hit I-P. >> >> This patch will require updating the state machine description in the >> "controller: avoid recomputes triggered by SBDB Port_Binding updates." patch >> when it's merged, as it changes the if-status state-machine. >> >> Signed-off-by: Xavier Simonart <xsimo...@redhat.com> >> --- > Hi Xavier, > > I only have a couple tiny style related remarks below. I think those > can be addressed at apply time if maintainers agree. Therefore: > > Acked-by: Dumitru Ceara <dce...@redhat.com> >
Hi Xavier, Unfortunately it seems this patch needs a rebase. Would it be possible for you to do that and also address the comments I had earlier in a new revision? Thanks, Dumitru _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
