On 11/4/22 22:45, Han Zhou wrote: > On Wed, Nov 2, 2022 at 7:46 AM Dumitru Ceara <dce...@redhat.com> wrote: >> >> On 11/2/22 15:35, Ales Musil wrote: >>> To prevent some jobs not running after CI scripts updates >>> use numbers instead of the test flags. This still allows us >>> to use parallelization, but without worrying about skipping >>> some tests by mistake. >>> >>> For "test" suites use 3 parts, with 1500 tests in mind. >>> That should give as additional space for future tests. >>> Currently, there is ~1200 tests. For sanitizers use 5 parts >>> instead, as they are slower in general. >>> >>> For "system-test" use 3 parts, with 300 tests in mind. >>> Currently, there is ~200 tests. >>> >>> In the end this patch reduces the number of jobs by 8 to 20, >>> which is ok as there is a limit of 20 running in parallel [0]. >>> >>> [0] > https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration#usage-limits >>> Signed-off-by: Ales Musil <amu...@redhat.com> >>> --- >> >> Thanks, Ales, for the patch! >> >> It makes it harder to skip tests by accident in CI which is great. >> >> But there's still the downside that maintainers need to pay a bit more >> attention so that the last run "1001-" or "201-" doesn't take way longer >> than the rest. > > I agree with this, but maybe not a big deal. So I am ok with it, too.
Actually, I have already missed this. :) Branches 22.03 and 22.06 have 2000+ tests because the test matrix depended on dp-groups being enabled/disabled too. That's not the case since >= 22.09. I still don't think it's a big deal in the end though. >> >> I'm OK with that but I wonder what Han, Mark and Numan think about this. >> >> If people are OK with it I can apply and backport the patch (assuming >> the CI is green [0]). > > Backporting may be a problem if the older branch doesn't have test 1200-. > Otherwise should be good. > I pushed this to the main branch and only backported to branch-22.09 for now. We have ~1300 tests there so we're ok. I'll wait with backporting to 22.06 and 22.03 for now. Thanks, Dumitru > Thanks, > Han > >> >> Regards, >> Dumitru >> >> [0] https://github.com/ovsrobot/ovn/actions/runs/3378478500 >> > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
