Re: [ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows

[Wilson Peng via dev]

Hi Simon,

Thanks for the comments and I have uploaded new patch with the
Updated notations in the patch. And also, I have updated the error log
Combined with the debug diff in the related reported issue
https://github.com/openvswitch/ovs-issues/issues/262


Regards
Wilson

From: dev <ovs-dev-boun...@openvswitch.org> on behalf of Simon Horman 
<simon.hor...@corigine.com>
Date: Wednesday, November 9, 2022 at 02:55
To: Wilson Peng <twofish...@hotmail.com>
Cc: d...@openvswitch.org <d...@openvswitch.org>
Subject: Re: [ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when 
creating netdev with system type on Windows
!! External Email

On Thu, Oct 13, 2022 at 10:50:51PM +0800, Wilson Peng wrote:

...

> @@ -165,8 +166,19 @@ netdev_windows_system_construct(struct netdev *netdev_)
>      if (strcmp(netdev_get_type(&netdev->up), "internal") && ret) {
>          return ret;
>      }
> +
>      ofpbuf_delete(buf);
>
> +    /* if ovs-type is "interna"l but the type of netdev->up
> +     * is "system" stop creating netdev. */

Hi Wilson,

I'm unsure of the correctness of this change, but I noticed the following.

nit:
       /* Don't create netdev if ovs-type is "internal"
        * but the type of netdev->up is "system". */

...
_______________________________________________
dev mailing list
d...@openvswitch.org
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-dev&amp;data=05%7C01%7Cpweisong%40vmware.com%7C503ddd9f027b4f18183c08dac1bad8d7%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638035305515306509%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=4cZEwqFTRyjVUa26Z1EIHbmZrtD1yotVJGueqRvYLZE%3D&amp;reserved=0

!! External Email: This email originated from outside of the organization. Do 
not click links or open attachments unless you recognize the sender.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev