On Tue, 2022-11-08 at 14:01 -0500, Simon Horman wrote:
> On Tue, Nov 08, 2022 at 01:17:57PM -0500, Dumitru Ceara wrote:
> > On 11/8/22 13:04, Dan Williams wrote:
> > > If no arguments are given report the current memory trim setting.
> > >
> > > Signed-off-by: Dan Williams <d...@redhat.com>
> > > ---
> >
> > Hi Dan,
> >
> > > ovsdb/ovsdb-server.c | 10 ++++++++--
> > > 1 file changed, 8 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c
> > > index 7a6bfe0a03c09..8c997cf5caf67 100644
> > > --- a/ovsdb/ovsdb-server.c
> > > +++ b/ovsdb/ovsdb-server.c
> > > @@ -431,7 +431,7 @@ main(int argc, char *argv[])
> > > unixctl_command_register("ovsdb-server/compact", "", 0, 1,
> > > ovsdb_server_compact, &all_dbs);
> > > unixctl_command_register("ovsdb-server/memory-trim-on-
> > > compaction",
> > > - "on|off", 1, 1,
> > > + "on|off", 0, 1,
> >
> > Can you please update the help too?
>
> In a similar vein, I wonder if ovsdb-server.1.in should be updated.
Talking with Ilya, he suggested a simpler approach for the actual
problem, which was continued logging when setting the same value.
Let's drop this one, I'll send a different patch.
Thanks,
Dan
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
