On Thu, Nov 24, 2022 at 6:31 AM Mike Pattrick <[email protected]> wrote: > > From: Flavio Leitner <[email protected]> > > The netdev receiving packets is supposed to provide the flags > indicating if the IP checksum was verified and it is GOOD or BAD, > otherwise the stack will check when appropriate by software. > > If the packet comes with good checksum, then postpone the > checksum calculation to the egress device if needed. > > When encapsulate a packet with that flag, set the checksum > of the inner IP header since that is not yet supported. > > Calculate the IP checksum when the packet is going to be sent over > a device that doesn't support the feature. > > Linux devices don't support IP checksum offload alone, so the > support is not enabled. > > Signed-off-by: Flavio Leitner <[email protected]> > Co-authored-by: Mike Pattrick <[email protected]> > Signed-off-by: Mike Pattrick <[email protected]>
I followed this series for a while, so this is okay for me, but I'd expect others find it hard to follow the differences in the revisions of the patches/series. You should provide a high level changelog in the cover letter, and add annotations per patch for more details. In any case, last revision looks good to me. The performance impact I was seeing with v8 in terms of basic fwd rate for a pvp setup is neglictable now. Reviewed-by: David Marchand <[email protected]> -- David Marchand _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
