On 12/15/22 09:31, Vladislav Odintsov wrote: > Hi Dumitru, > > Regards, > Vladislav Odintsov > >> On 12 Dec 2022, at 17:57, Dumitru Ceara <dce...@redhat.com> wrote: >> >> On 12/12/22 14:39, Vladislav Odintsov wrote: >>> Hi Numan, Dumitru, >>> >>> I forgot one thing about a possible upgrade recommendation for the users. >>> Fix can be applied much easier: just upgrading all ovn-ic in all AZs first >>> and then converting DB schema. This will remove all duplicates. >>> The latter can be requested manually invoking systemctl restart ovn-ic-db >>> (at least for RH, there is a separate systemd unit for IC databases) or >>> calling ovsdb-client convert … command directly. >>> >> >> This is a good point, especially because we don't define anywhere >> (AFAIK) an order of upgrading components when it comes to ovn-ic. >> >> We should document this in ovn-upgrades.rst. >> >>> Would it be an acceptable compromise for this situation? >> >> This has a long term implication though: ovn-ic must always be backwards >> compatible with ovn-ic-SB schema changes. That is not the case with >> ovn-northd and SB schema. If people think that's ok, I'm fine with that >> too but we need to make sure we properly document this. >> > > As nobody answers, should I: > 1. Split patch #3 by two: fix of duplicates (in order it do be backportable > to older branches) and the second part is an index changes + upgrade docs, > which will be a part of a major upgrade and will not be considered for > backporting. > 2. Describe in the second part, that if user upgrades from any version prior > to this major release it should upgrade all ovn-ic daemons on all > availability zones first and then upgrade ovn-ic-sb schema? > > If that has no objections, I’ll send a new patchset for a final review. >
I think that makes sense. Thanks again for working on this, looking forward to the new revision. Regards, Dumitru _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
