On 1/12/23 18:08, Han Zhou wrote: > For ovsdb clients that are short-lived, e.g. when using > ovn-nbctl/ovn-sbctl to read some metrics from the OVN NB/SB server, they > don't really need to be aware of db changes, because they exit > immediately after getting the initial response for the requested data. > In such use cases, however, the clients still send 'set_db_change_aware' > request, which results in server side error logs when the server tries > to send out the response for the 'set_db_change_aware' request, because > at the moment the client that is supposed to receive the request has > already closed the connection and exited. E.g.: > > 2023-01-10T18:23:29.431Z|00007|jsonrpc|WARN|unix#3: receive error: Connection > reset by peer > 2023-01-10T18:23:29.431Z|00008|reconnect|WARN|unix#3: connection dropped > (Connection reset by peer) > > To avoid such problems, this patch provides an API to allow a client to > choose to not send the 'set_db_change_aware' request. > > There was an earlier attempt to fix this [0], but it was not accepted > back then as discussed in the email [1]. It was also discussed in the > emails that an alternative approach is to use notification instead of > request, but that would require protocol changes and taking backward > compatibility into consideration. So this patch takes a different > approach and tries to keep the change small. > > [0] > http://patchwork.ozlabs.org/project/openvswitch/patch/1594380801-32134-1-git-send-email-dce...@redhat.com/ > > [1] > https://mail.openvswitch.org/pipermail/ovs-discuss/2021-February/050919.html > > Reported-by: Girish Moodalbail <gmoodalb...@nvidia.com> > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2020-July/050343.html > Reported-by: Tobias Hofmann <tohof...@cisco.com> > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2021-February/050914.html > Signed-off-by: Han Zhou <hz...@ovn.org> > Acked-by: Dumitru Ceara <dce...@redhat.com> > --- > v2: Addressed Dumitru's comments.
Thanks, Han and Dumitru! Applied (before branching). Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
