Thanks Dumitru!

Regards,
Vladislav Odintsov

> On 23 Jan 2023, at 17:58, Dumitru Ceara <dce...@redhat.com> wrote:
> 
> On 1/23/23 10:15, Simon Horman wrote:
>> On Sat, Jan 21, 2023 at 07:46:07PM +0300, Vladislav Odintsov wrote:
>>> There were two issues prior to this patch:
>>> 1. It was unable to have connectivity to networks over a router in
>>>   physical network connected through VTEP (ramp) gateway.
>>>   Consider next topology:
>>> 
>>>     ovn-nbctl lr-add lr1
>>>     ovn-nbctl lrp-add lr1 lrp1 00:00:00:00:00:01 10.0.0.1/24
>>>     ovn-nbctl ls-add ls1
>>>     ovn-nbctl lrp-add ls1 lsp1 -- \
>>>               lsp-set-addresses lsp1 router -- \
>>>               lsp-set-type lsp1 router -- \
>>>               lsp-set-options lsp1 router-port=lrp1
>>>     ovn-nbctl lsp-add ls1 lsp-vtep -- \
>>>               lsp-set-type lsp-vtep vtep -- \
>>>               lsp-set-addresses lsp-vtep unknown -- \
>>>               lsp-set-options lsp-vtep vtep-physical-switch=<..> 
>>> vtep-logical-switch=<..>
>>>     ovn-nbctl lr-route-add lr1 192.168.0.0/24 10.0.0.100
>>> 
>>>   If one issues ping from lsp1 to some address from 192.168.0.0/24 (via
>>>   vtep lsp), to enable routing support with vtep it is required to set
>>>   redirect chassis or ha chassis group on lrp1.  This topology didn't
>>>   provide connectivity.  Now such traffic flow will work properly.
>>> 
>>> 2. Traffic from lport in one subnet to vtep lport in another subnet of
>>>   same LR previously traversed via l3gw chassis, now in 'to vtep lport'
>>>   direction goes directly from hypervisor handling lport to VTEP (RAMP)
>>>   switch.  In the opposite direction traffic still goes from VTEP (RAMP)
>>>   switch through l3gw chassis and then to hypervisor.
>>> 
>>> The described functionality changes achieved by skipping to add
>>> gateway redirect logical flow for l3dgw ports which peers have datapath
>>> with logical switch ports of 'vtep' type.
>>> In this case traffic from hypervisor to VTEP (ramp) switch should go in
>>> distributed manner.  Only returning routed traffic must go through
>>> centralized gateway or ha-chassis-group.
>>> 
>>> This patch also updates relevant testcases to check the changed flows
>>> generation and port_binding:options:always-redirect logic.
>>> 
>>> Signed-off-by: Vladislav Odintsov <odiv...@gmail.com>
>> 
>> Thanks for the updates since v1, they look good to me.
>> 
>> FWIIW,
>> 
>> Reviewed-by: Simon Horman <simon.hor...@corigine.com>
>> _______________________________________________
> 
> Thanks, Vladislav and Simon!  I applied these two patches to the main
> branch.
> 
> Regards,
> Dumitru
> 

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to