On Mon, Jan 23, 2023 at 3:50 PM Simon Horman <simon.hor...@corigine.com> wrote: > > On Mon, Jan 23, 2023 at 03:29:50PM +0100, David Marchand wrote: > > On Mon, Jan 23, 2023 at 3:05 PM Ilya Maximets <i.maxim...@ovn.org> wrote: > > > > > > Test fails is 'nc' is not available, it should be skipped instead. > > > > > > > Probably not important, but: > > Fixes: b020a416e24c ("System Tests: Enhance NAT tests.") > > > Signed-off-by: Ilya Maximets <i.maxim...@ovn.org> > > > > Reviewed-by: David Marchand <david.march...@redhat.com> > > FWIIW, > > Reviewed-by: Simon Horman <simon.hor...@corigine.com> > > > Some notes: > > - in system-offloads-traffic.at, there is a similar issue, > > 5660b89a309d ("dpif-netlink: Offloading meter to tc police action") > > added calls to nc without checking nc availability, > > - in system-traffic.at, for "conntrack - ICMP related to original > > direction", there is no dependency to nc, so it is wrongly skipped if > > nc is missing, > > Agreed on both counts. > Would you like to post fixes? > Else I'm happy to do so.
Sorry, I only noticed your reply now. Please send the fixes, I'll review them. -- David Marchand _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev