On 1/26/23 22:36, Mike Pattrick wrote: > Hello Kevin, > > On Tue, Jan 24, 2023 at 5:00 AM Kevin Traynor <ktray...@redhat.com> wrote: >> >> pmd-perf-show with pmd-perf-metrics=true displays a histogram >> with averages. However, averages were not displayed when there >> is no iterations. >> >> They will be all zero so it is not hiding useful information >> but the stats look incomplete without them, especially when >> they are displayed for some PMD thread cores and not others. >> >> The histogram print is large and this is just an extra couple >> of lines, so might as well print them all the time to ensure >> that the user does not think there is something missing from >> the display. >> >> Before patch: >> Histograms >> cycles/it >> 499 0 >> 716 0 >> 1025 0 >> 1469 0 >> <snip> >> >> After patch: >> Histograms >> cycles/it >> 499 0 >> 716 0 >> 1025 0 >> 1469 0 >> <snip> >> --------------- >> cycles/it >> 0 >> >> Signed-off-by: Kevin Traynor <ktray...@redhat.com> > > Acked-by: Mike Pattrick <m...@redhat.com>
Thanks, Kevin and Mike! Applied both patches to master. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
