> -----Original Message----- > From: Ilya Maximets <i.maxim...@ovn.org> > Sent: Friday 27 January 2023 20:03 > To: Mike Pattrick <m...@redhat.com>; Adrián Moreno > <amore...@redhat.com>; Phelan, Michael <michael.phe...@intel.com> > Cc: d...@openvswitch.org; i.maxim...@ovn.org; Stokes, Ian > <ian.sto...@intel.com> > Subject: Re: [ovs-dev] [PATCH v2 1/2] ofproto-ipfix: use per-domain template > timeouts > > On 1/25/23 06:34, Mike Pattrick wrote: > > On Tue, Jan 24, 2023 at 2:21 PM Adrián Moreno <amore...@redhat.com> > wrote: > >> > >> From: Adrian Moreno <amore...@redhat.com> <snip> > >> +dnl Check templates (Flow ID = 0x02) where sent to ObservationDomain 1. > >> +AT_CHECK([test $(tcpdump -r ipfix.pcap --count "udp port 5555 and > >> +udp[[20:4]] = 0x00000001 and udp[[24:2]] = 0x02" 2>/dev/null | tr > >> +-d "packets") -gt 0]) > > > > These still seem to be getting "test: -gt: unary operator expected" > > errors on Intel CI, even after the modification. I'm at a loss as to > > why, the error message makes it seem like tcpdump is choking on the > > pcap and not writing anything to stdout. But the pcap should be > > present and readable. > > Yeah, I can't reproduce the failure happening on Intel CI as well. > > Michael, do you know what is happening with this test?
Hi Ilya, I have reran the test and received the same failure as reported on the mailing list, I'm not sure what exactly is going on with this test, maybe there is some prerequisite missing from our machine? Let me know if you need any more information. Thanks, Michael. > > OTOH, it might be better to take the road similar to how we test sflow and > netflow. I just found specific test binaries test-sflow and test-netflow > which are > just listening and printing out packtes in human-readable format. If we had > something like this for ipfix, we could write similar unit tests that do not > require > any external tools or root privileges, as we do for sflow and netflow. > > Thoughts? > > We might split this bug fix from the implementation of the unit test though, > since it will require a bit more code. > > Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
