On Wed, Feb 1, 2023 at 1:38 AM Dumitru Ceara <dce...@redhat.com> wrote:
>
> On 2/1/23 07:25, Han Zhou wrote:
> > Signed-off-by: Han Zhou <hz...@ovn.org>
> > ---
>
> Hi Han,
>
> Thanks for the fix!
>
> > ovn-nb.xml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ovn-nb.xml b/ovn-nb.xml
> > index 217eb877b055..929f4c966966 100644
> > --- a/ovn-nb.xml
> > +++ b/ovn-nb.xml
> > @@ -630,7 +630,7 @@
> > These options control IP Multicast Snooping configuration of
the
> > logical switch. To enable IP Multicast Snooping set
> > <ref column="other_config" key="mcast_snoop"/> to true. To
enable IP
> > - Multicast Querier set <ref column="other_config"
key="mcast_snoop"/>
> > + Multicast Querier set <ref column="other_config"
key="mcast_querier"/>
> > to true. If IP Multicast Querier is enabled
> > <ref column="other_config" key="mcast_eth_src"/> and
> > <ref column="other_config" key="mcast_ip4_src"/> must be set.
>
> This looks good to me so:
>
> Acked-by: Dumitru Ceara <dce...@redhat.com>
>
> But I'm wondering if we should also document the defaults:
>
> diff --git a/ovn-nb.xml b/ovn-nb.xml
> index 929f4c9669..4b52b99533 100644
> --- a/ovn-nb.xml
> +++ b/ovn-nb.xml
> @@ -638,10 +638,14 @@
> <column name="other_config" key="mcast_snoop"
> type='{"type": "boolean"}'>
> Enables/disables IP Multicast Snooping on the logical switch.
> + Default: <code>false</code>.
> </column>
> <column name="other_config" key="mcast_querier"
> type='{"type": "boolean"}'>
> Enables/disables IP Multicast Querier on the logical switch.
> + Only applicable if <ref column="other_config" key="mcast_snoop"/>
> + is enabled.
> + Default: <code>true</code>.
> </column>
> <column name="other_config" key="mcast_flood_unregistered"
> type='{"type": "boolean"}'>
> ---
>
> If you agree, do you think it's OK to squash this into your patch
> before applying it?
>
> Thanks,
> Dumitru
>
>
Thanks Dumitru! I folded your change into the patch and applied to main.
Han
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
