On Tue, Jan 17, 2023 at 6:13 PM Ilya Maximets <i.maxim...@ovn.org> wrote: > > Current numa.h header for sparse re-defines functions in a way > that breaks the header from libnuma 2.0.13+, because the original > issue was fixed in that version: > > https://github.com/numactl/numactl/commit/25dcde021dd4f1a1dcac2ba0094f1cb441a2e4a5 > > Sparse errors as a result: > > lib/netdev-afxdp.c: note: in included file (through include/sparse/numa.h): > /usr/include/numa.h:346:26: error: macro "numa_get_interleave_mask_compat" > passed 1 arguments, but takes just 0 > /usr/include/numa.h:376:26: error: macro "numa_get_membind_compat" > passed 1 arguments, but takes just 0 > /usr/include/numa.h:406:26: error: macro "numa_get_run_node_mask_compat" > passed 1 arguments, but takes just 0 > /usr/include/numa.h:347:1: error: Expected ; at end of declaration > /usr/include/numa.h:347:1: error: got { > /usr/include/numa.h:351:9: error: 'tp' has implicit type > > It's hard to adjust defines to work with both versions of a header. > Just defining all the functions we actually use in OVS instead and > not including the original header. > > Fixes: e8568993e062 ("netdev-afxdp: NUMA-aware memory allocation for XSK > related memory.") > Signed-off-by: Ilya Maximets <i.maxim...@ovn.org>
Reviewed-by: David Marchand <david.march...@redhat.com> -- David Marchand _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
