Hi, Jiri:
Difference between v5 and v4 are a wrap to fix max-line-length warning
- cpumask_set_cpu(cpu,
&flow->cpu_used_mask);
+ cpumask_set_cpu(cpu,
+ flow->cpu_used_mask);
I will make the newer submission contain the diff from previous one in the next
submission.
sorry for the inconvenience
eddy
________________________________
发件人: Jiri Pirko <j...@resnulli.us>
发送时间: 2023年2月3日 11:55
收件人: 陶 缘 <taoyuan_e...@hotmail.com>
抄送: net...@vger.kernel.org <net...@vger.kernel.org>; Pravin B Shelar
<pshe...@ovn.org>; David S. Miller <da...@davemloft.net>; Eric Dumazet
<eduma...@google.com>; Jakub Kicinski <k...@kernel.org>; Paolo Abeni
<pab...@redhat.com>; d...@openvswitch.org <d...@openvswitch.org>;
linux-ker...@vger.kernel.org <linux-ker...@vger.kernel.org>
主题: Re: 回复: [PATCH net-next v5 1/1] net:openvswitch:reduce cpu_used_mask memory
Fri, Feb 03, 2023 at 10:03:28AM CET, taoyuan_e...@hotmail.com wrote:
>sorry, Jiri, my bad, will hold on before the next submission/hope it is the
>final one
Don't top-post please. So what is the change comparing to v4?
>
>eddy
>________________________________
>发件人: Jiri Pirko <j...@resnulli.us>
>发送时间: 2023年2月3日 9:00
>收件人: Eddy Tao <taoyuan_e...@hotmail.com>
>抄送: net...@vger.kernel.org <net...@vger.kernel.org>; Pravin B Shelar
><pshe...@ovn.org>; David S. Miller <da...@davemloft.net>; Eric Dumazet
><eduma...@google.com>; Jakub Kicinski <k...@kernel.org>; Paolo Abeni
><pab...@redhat.com>; d...@openvswitch.org <d...@openvswitch.org>;
>linux-ker...@vger.kernel.org <linux-ker...@vger.kernel.org>
>主题: Re: [PATCH net-next v5 1/1] net:openvswitch:reduce cpu_used_mask memory
>
>Fri, Feb 03, 2023 at 09:52:56AM CET, taoyuan_e...@hotmail.com wrote:
>>Use actual CPU number instead of hardcoded value to decide the size
>>of 'cpu_used_mask' in 'struct sw_flow'. Below is the reason.
>>
>>'struct cpumask cpu_used_mask' is embedded in struct sw_flow.
>>Its size is hardcoded to CONFIG_NR_CPUS bits, which can be
>>8192 by default, it costs memory and slows down ovs_flow_alloc
>>
>>To address this, redefine cpu_used_mask to pointer
>>append cpumask_size() bytes after 'stat' to hold cpumask
>>
>>cpumask APIs like cpumask_next and cpumask_set_cpu never access
>>bits beyond cpu count, cpumask_size() bytes of memory is enough
>>
>>Signed-off-by: Eddy Tao <taoyuan_e...@hotmail.com>
>
>Eddy, could you please slow down a bit? Why did you send v5 right
>after v4? Could you please always put a changelog to the patch
>submitted to contain info about changes in between the
>submitted version?
>
>Thanks!
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
