On 2/1/23 12:12, Eelco Chaudron wrote: > When a flow gets modified, i.e. the actions are changes, the tc layer will > remove, and re-add the flow. This is causing all the counters to be reset. > > This patch will remember the previous tc counters and adjust any requests > for statistics. This is done in a similar way as the rte_flow implementation. > > It also updates the check_pkt_len tc test to purge the flows, so we do > not use existing updated tc flow counters, but start with fresh installed > set of datapath flows. > > Signed-off-by: Eelco Chaudron <echau...@redhat.com> > --- > Please note that for now two copies of the test case exists, but I will clean > this up once this gets applied by submitting a new revision of the > 'tests: Add system-traffic.at tests to check-offloads' series. > > -v2: Do not update the stats->used, as in terse dump they should be 0. > -v3: Added some comments based on the v2 review. > -v4: Re-based on latest upstream master. > Updated commit message. > Updated system-traffic test name. > Fixed byte counter usage in check_pkt_lent test cases. > Synced both new tests to use the same byte counter approach. > > lib/netdev-offload-tc.c | 99 > ++++++++++++++++++++++++++++++++------ > lib/tc.h | 1 > tests/system-offloads-traffic.at | 78 +++++++++++++++++++++++++++--- > tests/system-traffic.at | 64 +++++++++++++++++++++++++ > 4 files changed, 219 insertions(+), 23 deletions(-)
Thanks! I moved the normal system test from the 'NSH' section to 'datapath'. With that, applied and backported down to 2.17. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
