On Wed, Feb 22, 2023 at 06:31:55PM +0900, Nobuhiro MIKI wrote:
> On 2023/02/22 18:04, Simon Horman wrote:
> > On Wed, Feb 22, 2023 at 05:12:36PM +0900, Nobuhiro MIKI wrote:

...

> >> diff --git a/ofproto/ofproto-tnl-unixctl.man 
> >> b/ofproto/ofproto-tnl-unixctl.man
> >> index 13a465119a90..0af9246dab2e 100644
> >> --- a/ofproto/ofproto-tnl-unixctl.man
> >> +++ b/ofproto/ofproto-tnl-unixctl.man
> >> @@ -1,8 +1,9 @@
> >>  .SS "OPENVSWITCH TUNNELING COMMANDS"
> >>  These commands query and modify OVS tunnel components.
> >>  .
> >> -.IP "\fBovs/route/add ipv4_address/plen output_bridge [GW]\fR"
> >> -Adds ipv4_address/plen route to vswitchd routing table. output_bridge
> >> +.IP "\fBovs/route/add \fIip\fB/\fIplen\fB \fIoutput_bridge\fB \
> >> +[\fIgateway\fB] [pkt_mark=\fImark\fB] [src=\fIsrc_ip\fB]\fR"
> >> +Adds \fIip\fR/\fIplen\fR route to vswitchd routing table. 
> >> \fIoutput_bridge\fR
> >>  needs to be OVS bridge name.  This command is useful if OVS cached
> >>  routes does not look right.
> >>  .
> > 
> > nit: I think the ipv4_address -> ip change should be a separate patch,
> >      which also fixes any other instances of this.
> > 
> > ...
> 
> OK. Before this patch, perform these replacements in another patch.

Yes, I think that would be best.
Thanks!
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to