Hi Simon,
Thanks for the update. I will send v3 with nits addreesed.
Thanks,
Naveen
> On 15-Mar-2023, at 2:24 PM, Simon Horman <simon.hor...@corigine.com> wrote:
>
> On Wed, Mar 15, 2023 at 08:27:40AM +0000, Naveen Yerramneni wrote:
>> Hi Simon,
>>
>> Thanks, I will wait for your review.
>>
>> Multiple patches were sent out due to my mistake, my apologies for that.
>
> Understood, sorry for jumping the gun a bit there.
>
>> Thanks,
>> Naveen
>>
>>
>>> On 14-Mar-2023, at 6:17 PM, Simon Horman <simon.hor...@corigine.com> wrote:
>>>
>>> On Tue, Mar 14, 2023 at 10:51:55AM +0000, Naveen Yerramneni wrote:
>>>> Add OpenFlow extn to set conntrack entries limit per zone.
>>>>
>>>> Signed-off-by: Naveen Yerramneni <naveen.yerramn...@nutanix.com>
>>>
>>> Hi Naveen,
>>>
>>> There were 4 postings of this patchset yesterday, and one so far today.
>>> Please consider allowing 24h between postings to give reviewers a chance to
>>> look at things.
>>>
>>> Overall this patch looks nice to me, I reviewed it with reference to:
>>>
>>> 2a7c4805a76d ("Add OpenFlow command to flush conntrack table entries.")
>>>
>>> Some minor comments inline.
>>>
>>> I will run some tests over it.
>>> And respond further if that shows up anything of interest.
>
> I did run the automated workflow over this [1].
> Including check-offloads [2].
> And things seem clean to me.
>
> So with the minor nits in my previous email addressed:
>
> Reviewed-by: Simon Horman <simon.hor...@corigine.com>
>
> [1]
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_horms_ovs_actions_runs_4415889468&d=DwIBAg&c=s883GpUCOChKOHiocYtGcg&r=2PQjSDR7A28z1kXE1ptSm6X36oL_nCq1XxeEt7FkLmA&m=1ULPoISx8VbNNUUySPVpF590U5f5xd19I9VzrZ49p5qRiK4_DMTkx2kW7x9uY55Q&s=pAhfSRiPDj3ees57ibAJlo2tAut2yPd_kIKekNDMpa4&e=
>
> [2]
> https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_pipermail_ovs-2Ddev_2023-2DMarch_402672.html&d=DwIBAg&c=s883GpUCOChKOHiocYtGcg&r=2PQjSDR7A28z1kXE1ptSm6X36oL_nCq1XxeEt7FkLmA&m=1ULPoISx8VbNNUUySPVpF590U5f5xd19I9VzrZ49p5qRiK4_DMTkx2kW7x9uY55Q&s=6ihLNNSY3oKIqfrhSJAWPXjH8G2KD-3NzQTcj9VdLr8&e=
>
>
>>>
>>> ...
>>>
>>>> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
>>>> index f87e27a8c..6797cebac 100644
>>>> --- a/ofproto/ofproto-dpif.c
>>>> +++ b/ofproto/ofproto-dpif.c
>>>> @@ -5631,6 +5631,27 @@ ct_del_zone_timeout_policy(const char
>>>> *datapath_type, uint16_t zone_id)
>>>> }
>>>> }
>>>>
>>>> +static void
>>>> +ct_set_zone_limit(const struct ofproto *ofproto_, const uint16_t zone_id,
>>>> + const uint32_t limit)
>>>> +{
>>>> + struct ofproto_dpif *ofproto = ofproto_dpif_cast(ofproto_);
>>>> + struct ovs_list zone_limits = OVS_LIST_INITIALIZER(&zone_limits);
>>>> +
>>>> + ct_dpif_push_zone_limit(&zone_limits, zone_id, limit, 0);
>>>> + int err = ct_dpif_set_limits(ofproto->backer->dpif, NULL,
>>>> &zone_limits);
>>>> + if (err) {
>>>> + VLOG_ERR_RL(&rl, "failed to set zone limit id=%"PRIu16", "
>>>> + "limit=%"PRIu32" (%s)", zone_id, limit,
>>>> + ovs_strerror(err));
>>>> + } else {
>>>> + VLOG_DBG("configured zone limit for zone=%"PRIu16",
>>>> limit=%"PRIu32"",
>>>> + zone_id, limit);
>>>> + }
>>>> +
>>>> + ct_dpif_free_zone_limits(&zone_limits);
>>>
>>> nit: the two lines line above have trailing whitespace.
>>>
>>>> +}
>>>> +
>>>
>>> ...
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
