On 3/31/23 14:46, Vladislav Odintsov wrote: > Hi Dumitru, > >> On 31 Mar 2023, at 15:01, Dumitru Ceara <[email protected]> wrote: >> >> On 3/31/23 11:43, Ales Musil wrote: >>> On Thu, Mar 23, 2023 at 8:25 PM Vladislav Odintsov <[email protected]> >>> wrote: >>> >>>> For large OVN_Southbound DBs defatult interval of 5000 ms could be not >>>> sufficient. This patch disables OVSDB inactivity probes for ovn-*ctl >>>> running >>>> in non-daemon mode. >>>> >>>> Signed-off-by: Vladislav Odintsov <[email protected]> >>>> --- >>>> utilities/ovn-dbctl.c | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/utilities/ovn-dbctl.c b/utilities/ovn-dbctl.c >>>> index 369a6a663..4307a5cae 100644 >>>> --- a/utilities/ovn-dbctl.c >>>> +++ b/utilities/ovn-dbctl.c >>>> @@ -208,6 +208,9 @@ ovn_dbctl_main(int argc, char *argv[], >>>> if (daemon_mode) { >>>> server_loop(dbctl_options, idl, argc, argv_); >>>> } else { >>>> + /* Disable OVSDB probe interval for non-daemon mode. */ >>>> + ovsdb_idl_set_probe_interval(idl, 0); >> >> I think I'd avoid using the idl function directly and call instead: >> >> set_idl_probe_interval(idl, 0); >> >> Just to keep it aligned with all other uses in OVN. I can patch that at >> apply time if it looks OK to you. > > I’ve got no objections here. > Small nit: set_idl_probe_interval function needs also a remote. Like this: > > set_idl_probe_interval(idl, db, 0); > > Also, please correct typo in commit message: defatult -> default. >
In light of the ovs-discuss thread [0] is it maybe better to just set this probe interval to a very high value instead? That's for the case when ovn-nbctl/sbctl daemon <-> ovsdb-server connection dies because of for example cable being unplugged somewhere on the way between the two. [0] https://mail.openvswitch.org/pipermail/ovs-discuss/2023-March/052324.html >> >>>> + >>>> struct ctl_command *commands; >>>> size_t n_commands; >>>> char *error; >>>> -- >>>> 2.36.1 >>>> >>>> _______________________________________________ >>>> dev mailing list >>>> [email protected] >>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >>>> >>>> >>> Looks good to me, thanks. >>> >>> Reviewed-by: Ales Musil <[email protected]> >>> >> >> Vladislav, Ales, I was thinking of backporting this to stable branches >> too, what do you think? >> >> Thanks, >> Dumitru > > > Regards, > Vladislav Odintsov > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
