On Mon, Apr 17, 2023 at 06:28:13PM +0200, David Marchand wrote:
> Caught during some code review.
> The incriminated commit had put an unneeded check on tc ingress support
> for the meter offloading test.
>
> Note: SUPPORT_TC_INGRESS_PPS had been reworked in the commit 5f0fdf5e2c2e
> ("test: Move check for tc ingress pps support to test script.").
>
> Fixes: 5660b89a309d ("dpif-netlink: Offloading meter to tc police action")
> Signed-off-by: David Marchand <david.march...@redhat.com>
Hi David,
I am slightly confused by this.
1. The test in question is for hardware offload of metering,
which will use the TC datapath.
2. The test creates a meter with pktps (PPS) rate limiting,
which will lead to the creation of a TC police action with a PPS rate.
3. SUPPORT_TC_INGRESS_PPS is intended to check if
TC police action with PPS rate is supported by the kernel.
I feel that I am missing something obvious here.
> ---
> tests/system-offloads-traffic.at | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/system-offloads-traffic.at
> b/tests/system-offloads-traffic.at
> index da18597cd8..df43caa9e5 100644
> --- a/tests/system-offloads-traffic.at
> +++ b/tests/system-offloads-traffic.at
> @@ -240,7 +240,6 @@ AT_CLEANUP
>
> AT_SETUP([offloads - check interface meter offloading - offloads enabled])
> AT_KEYWORDS([offload-meter])
> -AT_SKIP_IF([test $SUPPORT_TC_INGRESS_PPS = "no"])
> AT_SKIP_IF([test $HAVE_NC = "no"])
> OVS_TRAFFIC_VSWITCHD_START([], [], [-- set Open_vSwitch .
> other_config:hw-offload=true])
>
> --
> 2.39.2
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
