On 5/4/23 19:10, David Marchand wrote: > Let's separate DPDK compilation from the rest of OVS build: > - this avoids multiple jobs building DPDK in parallel, which especially > affects builds in the dpdk-latest branch, > - we separate concerns about DPDK build requirements from OVS build > requirements, like python dependencies, > - building DPDK does not depend on how we will link OVS against it, so we > can use a single cache entry regardless of DPDK_SHARED option, > > Reviewed-by: Simon Horman <simon.hor...@corigine.com> > Signed-off-by: David Marchand <david.march...@redhat.com> > --- > Changes since v3: > - fixed git log trace, > - set DPDK_GIT explicitly in yml, > > Changes since v2: > - removed unneeded checks when the cache is hit, > - exposed the cache key computed in the first stage of the build > pipeline, and reused it for the second stage, > > Changes since v1: > - filtered dpdk build job dependencies: it only needs gcc, ninja and > libnuma-dev, > - removed matrix configuration for dpdk build single job, > - skipped most of the dpdk build job steps on cache hit, > - for dpdk-latest, DPDK_VER may refer to a branch. The cache key has > been updated to contain the git repository HEAD commit identifier, > and any reference to DPDK from the .github/ configuration files, > - removed libelf-dev and ninja from linux jobs dependencies, > > --- > .ci/dpdk-build.sh | 54 +++++++++++++++++ > .ci/dpdk-prepare.sh | 11 ++++ > .ci/linux-build.sh | 64 ++------------------ > .ci/linux-prepare.sh | 3 +- > .github/workflows/build-and-test.yml | 89 ++++++++++++++++++++++------ > Makefile.am | 2 + > 6 files changed, 145 insertions(+), 78 deletions(-) > create mode 100755 .ci/dpdk-build.sh > create mode 100755 .ci/dpdk-prepare.sh
Thanks, David! I applied this to master and also to 3.1 (it applies cleanly and it's better to keep CI aligned). And I rebased the dpdk-latest branch on top of this change. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
