On Fri, May 5, 2023 at 9:41 PM Ilya Maximets <i.maxim...@ovn.org> wrote: > > On 5/3/23 00:20, Christophe Fontaine wrote: > > Current tx_steering mode has to be configured on each Interface. > > The global config option "vhost-tx-steering-default" allows > > the user to select a default mode (thread or hash) for > > all dpdkvhost ports. > > > > Signed-off-by: Christophe Fontaine <cfont...@redhat.com> > > Hi, Christophe. Thanks for the patch! > > The idea is interesting. However, despite the name, the option > in the current implementation will affect every port including > physical ones. And I don't think that is intended behavior. > > Also, we should not have options specific to a particular port > type in the generic datapath code. We have one ugly 'is_vhost' > check, but it shouldn't really exist. > > One solution might be to have a generic default option like > 'tx-steering-default', but it should be clearly documented that > it affects all ports. Then users can set the 'thread' mode for > ports they want to not use 'hash'.
Thanks for the review Ilya, I get your point that a global conf shouldn't affect only a specific type of ports. I'll abandon this patch, and submit another one, which will affect all ports. Christophe > > Best regards, Ilya Maximets. > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
