On 5/3/23 22:13, Ihar Hrachyshka wrote: > The new tables will be used in a later patch as follows: > > table=37, OFTABLE_OUTPUT_INIT: becomes an initial entry point into the > egress pipeline that serves a semantic goal. (Not doing any actual > processing at the moment.) > > table=38, OFTABLE_OUTPUT_LARGE_PKT_DETECT: detect "too-big" IP packets > and mark them for later processing in table=39. > > table=39, OFTABLE_OUTPUT_LARGE_PKT_PROCESS: process "too-big" IP packets > detected in table=38 by sending ICMPv4 Fragmentation Needed / ICMPv6 Too > Big errors back to the originating port. > > All previous table indices shifted by 3 (old table=37 becomes table=40). > Otherwise, no changes to existing tables and flows introduced. > > Signed-off-by: Ihar Hrachyshka <ihrac...@redhat.com> > ---
Hi Ihar, > > diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml > index cb1064f71..306821d69 100644 > --- a/ovn-architecture.7.xml > +++ b/ovn-architecture.7.xml > @@ -1233,8 +1233,8 @@ > output port field, and since they do not carry a logical output port > field in the tunnel key, when a packet is received from ramp switch > VXLAN tunnel by an OVN hypervisor, the packet is resubmitted to > table 8 > - to determine the output port(s); when the packet reaches table 37, > - these packets are resubmitted to table 38 for local delivery by > + to determine the output port(s); when the packet reaches table 40, > + these packets are resubmitted to table 41 for local delivery by > checking a MLF_RCV_FROM_RAMP flag, which is set when the packet > arrives from a ramp tunnel. > </p> > @@ -1439,38 +1439,42 @@ > > <li> > <p> > - OpenFlow tables 37 through 39 implement the <code>output</code> > action > - in the logical ingress pipeline. Specifically, table 37 handles > - packets to remote hypervisors, table 38 handles packets to the local > - hypervisor, and table 39 checks whether packets whose logical ingress > - and egress port are the same should be discarded. > + OpenFlow tables 37 through 42 implement the <code>output</code> > action > + in the logical ingress pipeline. Specifically, table 37 serves as an > + entry point to egress pipeline. Table 38 detects IP packets that are > + too big for a corresponding interface. Table 39 produces ICMPv4 > + Fragmentation Needed (or ICMPv6 Too Big) errors and deliver them back Nit: This part is inaccurate, right? We don't do anything like that in tables 37 & 38 yet. The rest looks good to me so feel free to add my ack to the next revision: Acked-by: Dumitru Ceara <dce...@redhat.com> Thanks, Dumitru _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
