On Sat, May 20, 2023 at 02:31:18AM +0200, Ilya Maximets wrote:
> GRE sequence number is maintained as part of the tunnel config.
> This triggers tunnel reconfiguration every time set_tunnel_config()
> is called, because memset over tunnel config will never be equal to
> the new config constructed from database options.
>
> And sequence number incremented non-atomically without holding a
> mutex on tunnel push, that may lead to corruption if multiple
> threads are sending packets to the same tunnel.
>
> Fix that by moving sequence number to the netdev_vport structure
> instead and using an atomic counter.
>
> Fixes: 0ffff4975308 ("userspace: add gre sequence number support.")
> Fixes: 7dc18ae96d33 ("userspace: add erspan tunnel support.")
> Fixes: 3c6d05a02e0f ("userspace: Add GTP-U support.")
> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org>
Reviewed-by: Simon Horman <simon.hor...@corigine.com>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
