On 5/25/23 15:20, Simon Horman wrote: > On Wed, May 17, 2023 at 06:51:05PM +0200, Ilya Maximets wrote: >> Many OVSDB tests are not checking the server log for warnings or >> errors. Some are not even using the log file. It's mostly OK as we're >> usually checking the user-visible behavior. But it would also be nice >> to detect some internal warnings if there are some. >> >> Moving the OVSDB_SERVER_SHUTDOWN macro to the common place, adding >> the call to check_logs into it and making OVSDB tests use this macro. >> >> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org> > > Reviewed-by: Simon Horman <simon.hor...@corigine.com> > > As an aside. > Some of the lines in the test suite are excessively long. >
I guess, I can post v2 trying to wrap some lines that this patch is touching. I just thought it would be harder to review this way. What do you think? Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
