Hi Simon, On Mon, Jun 12, 2023 at 10:56 PM Simon Horman <simon.hor...@corigine.com> wrote: > > On Mon, Jun 05, 2023 at 01:30:03AM +0800, James Raphael Tiovalen wrote: > > This commit adds a few null pointer assertions and checks to some return > > values of `ovsdb_table_schema_get_column`. If a null pointer is > > encountered in these blocks, either the assertion will fail or the > > control flow will now be redirected to alternative paths which will > > output the appropriate error messages. > > > > Signed-off-by: James Raphael Tiovalen <jamestio...@gmail.com> > > Reviewed-by: Simon Horman <simon.hor...@corigine.com> > > Hi James, > > unfortunately the CI is showing a number of failures with this patch > applied. I haven't dug into them, but the first is the "ovsdb-server rbac" > test for the "linux gcc test" run. > > Link: > https://github.com/ovsrobot/ovs/actions/runs/5170413012/jobs/9313335549#step:11:5574
I have identified the cause of the test failures. The commit d56366bfa05b90e7b610716ebf9164bfd06e25f1 added a check for ovsdb-server logs for any warnings or errors. Since this patch adds an additional error message in the `ovsdb_util_write_string_string_column` function, which is unexpected from the perspective of some of those tests, they fail. To fix this, we can simply add the error messages as expected to the ALLOWLIST of the OVSDB_SERVER_SHUTDOWN statements within the tests. That said, I do have one question before I submit the next version of this patch. Should I change the log severity from an error to a warning instead since it seems that there are test cases that will print the log message? Or should I keep it as an error? Best regards, James Raphael Tiovalen _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
