Ok, I will fix these. ---- Simon Jones
Ilya Maximets <i.maxim...@ovn.org> 于2023年7月4日周二 21:35写道： > On 7/3/23 05:46, 冮晔维 wrote: > > From: gangyewei <gan...@yusur.tech> > > Hi. Thanks for the update! Please, add a version number while > sending new versions though, e.g. [PATCH v2]. Otherwise, it's > hard to track which version is the most recent one. > > > Fix bug of ovs-tcpdump, which will cause megaflow action wrong. > > As use ovs-tcpdump will add mipxxx NIC, and this NIC has IPv6 address by > default. > > For vxlan topology, mipxxx will be treated as tunnel port, and will got > error actions. > > For detail discuss, refer email of ovs-discuss titled in "[BUG] > [ovs-tcpdump] Got duplicate ...". > > If you want to cite the discussion, you need to provide a link > to a public web archive. It'll be hard to find this discussion > for someone who didn't participate in it. In your case the > issue was reported in the mail thread, so you can use the tag > instead: > > Reported-at: <link> > > And there should be an empty line between the commit message > and the tags. > > Also, please remove dashes from the subject line. And make it > a bit more specific to the problem you're trying to solve. > > There are some guidelines on patch formatting here: > > https://docs.openvswitch.org/en/latest/internals/contributing/submitting-patches/ > > > Signed-off-by: gangyewei <gan...@yusur.tech> > > --- > > utilities/ovs-tcpdump.in | 4 ++++ > > 1 file changed, 4 insertions(+) > > diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in > > index 420c11eb8..4cbd9a5d3 100755 > > --- a/utilities/ovs-tcpdump.in > > +++ b/utilities/ovs-tcpdump.in > > @@ -96,6 +96,10 @@ def _install_dst_if_linux(tap_name, mtu_value=None): > > *(['ip', 'link', 'set', 'dev', str(tap_name), 'up'])) > > pipe.wait() > > + pipe = _doexec( > > + *(['ip', '-6', 'addr', 'flush', 'dev', str(tap_name)])) > > + pipe.wait() > > + > > def _remove_dst_if_linux(tap_name): > > _doexec( > > This patch is not correctly formatted. > Looks like your mail client mangled the spaces and now the patch > is not applicable: > > Applying: ovs-tcpdump: Bugfix-of-ovs-tcpdump. > error: corrupt patch at line 20 > error: could not build fake ancestor > Patch failed at 0001 ovs-tcpdump: Bugfix-of-ovs-tcpdump. > > If you can't configure your mail client to not do that, you may > want to try a different client, e.g. "git send-email". > > Best regards, Ilya Maximets. > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
